Skip to content

Conversation

0xllx0
Copy link
Contributor

@0xllx0 0xllx0 commented Sep 11, 2025

Adds the miselect register for selecting an indirect CSR according to the Smcsrind extension.

Related: #1, #226

Adds the `miselect` register for selecting an indirect CSR according to
the `Smcsrind` extension.

Reference:

<https://riscv-software-src.github.io/riscv-unified-db/manual/html/isa/isa_20240411/chapters/indirect-csr.html>
@0xllx0 0xllx0 requested a review from a team as a code owner September 11, 2025 00:09
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! A minor comment regarding the changelog file.

@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
and the target interrupt source.
- Add `mseccfg` CSR
- Add `mseccfgh` CSR
- Add `miselect` CSR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, create a new ### Added section under ##[Unreleased] and add your changes there.

Adds a basic unit test for the `miselect` CSR.
@0xllx0 0xllx0 force-pushed the riscv/register/miselect branch from 4bfaa1a to b4385d0 Compare September 12, 2025 00:44
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romancardenas romancardenas added this pull request to the merge queue Sep 16, 2025
Merged via the queue into rust-embedded:master with commit c0cbc1c Sep 16, 2025
139 checks passed
@0xllx0 0xllx0 deleted the riscv/register/miselect branch September 18, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants